Second Brain

Halt SDR test coverage uplift on QuotationExtn / InventoryCostServices via test changes alone

1 min read

Halt SDR test coverage uplift on QuotationExtn / InventoryCostServices via test changes alone

Decision

Stop iterating on test class fixes for QuotationExtn (36.42%) and InventoryCostServices (38.02%) coverage. Surface the QuotationExtn constructor SOQL bloat as a code-fix request to the developer (Amitabh Saasworx). Verify org-wide coverage as cheaper fallback before committing to constructor refactor.

Rationale

QuotationExtn was modified 29-Apr-2026 10:59 IST. Constructor now does 30+ SOQL via checkCarParkAvailablity (11 hasAvailable calls) + loadProjectAvailability + init. Any test that calls new QuotationExtn() with a real fixture exceeds 100 SOQL inside . Test.startTest doesn’t help because constructor alone exceeds budget. No amount of fixture trimming or test-method splitting can fix this from the test side. trgToUpdateOppStageHandler (84.97%) and QuotationManagementServices (80.09%) already pass 75%, so the per-class blocker is isolated to two classes that share the same constructor-SOQL root cause.

Alternatives Rejected

  1. Refactor QuotationExtn constructor ourselves — rejected per AJ’s standing directive: do not modify existing sandbox code without asking. 2) Continue iterating on test fixtures with smaller data — rejected: fixture isn’t the bottleneck, constructor is. 3) Use seeAllData=true to reuse org data — rejected: brittle, not deterministic, doesn’t reduce constructor SOQL count.

Outcome

Pending

Graph View

Backlinks