Second Brain

Cancellation/Transfer/Upgrade module is NOT READY for production — wit…

2 min read

Cancellation/Transfer/Upgrade module is NOT READY for production — wit…

Decision

Cancellation/Transfer/Upgrade module is NOT READY for production — withhold deployment until two P0 blockers are closed: (1) RW_UnitTransferAndCancellation writes invalid picklist value ‘Upgrade In Process’ (picklist has only ‘Upgrade In Progress’); (2) sendApprovalRequest() overwrites Sales Approvers Team-derived Level_Two/Three_Approver values with Project.CRMHead/Overall_CRM_Head before approval submission, making the User Manual section 7 misleading.

Rationale

Comprehensive fullcopy audit verified: data model is correct (Team__c with Sales Approvers Team type, Team_Members__c with First/Second/Third Level, Booking has Level_One/Two/Three_Approver fields, Quotation has matching fields), QuotationExtn correctly populates approvers from Sales Approvers Team via QuotationManagementServices.getApprovers(Project__c). However sendApprovalRequest()/sendApprovalRequestforUnitTransfer() in RW_UnitTransferAndCancellation contain explicit code that overwrites Level_Two_Approver=Project.CRMHead__c and Level_Three_Approver=Project.Overall_CRM_Head__c right before Approval.process() submission - making the upstream Sales Approvers Team setup cosmetic. Separately, status picklist literal ‘Upgrade In Process’ written by Apex is invalid - picklist has ‘Upgrade In Progress’. Both bugs persist from prior 07-Apr-2026 audit (PARTIAL-2). Two fixes are 5-min and 15-min code edits respectively. Carryover P1 gaps (RERA flag, team/process tracking, involuntary notice chain, demand reversal automation, refund SLA) are silent in the new User Manual - need explicit business call on in/out of scope. Naming mismatches between User Manual and deployed schema (Type of Booking vs Type_of_Sale__c, Original_* vs Cancelled_*, Cancellation In Progress vs Cancellation Initiated, Cancellation Description vs Cancellation_Descrption__c) are doc-fix items not code bugs.

Alternatives Rejected

Outcome

Pending

Graph View

Backlinks